Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple useas modes #272

Merged

Conversation

srikumar003
Copy link
Collaborator

Fixes #271

BY merging this PR, the following pod definition

apiVersion: v1
kind: Pod
metadata:
  name: busybox
  labels:
    app: busybox
    dataset.0.id: "tests3a"
    dataset.0.useas: "mount.configmap"

will lead to a pod definition like below:

apiVersion: v1
kind: Pod
metadata:
...
spec:
  containers:
...
    envFrom:
    - configMapRef:
        name: tests3a
      prefix: tests3a_
    - prefix: tests3a_
      secretRef:
        name: tests3a
...
    volumeMounts:
...
    - mountPath: /mnt/datasets/tests3a
      name: tests3a
...
  volumes:
...
  - name: tests3a
    persistentVolumeClaim:
      claimName: tests3a

Signed-off-by: SRIKUMAR VENUGOPAL <srikumarv@ie.ibm.com>
@srikumar003 srikumar003 added enhancement New feature or request size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 4, 2023
@srikumar003 srikumar003 merged commit 1691e24 into datashim-io:master Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Support multiple useas modes for a dataset
1 participant