Update merge-requires.yml #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debug release action AB#10062 Signed-off-by: Paul Hewlett <1104895+eccles@users.noreply.github.com>
eccles
force-pushed
the
eccles-patch-1
branch
from
805ae9d to
ab51ab9
Compare
Fix github action Remove the release requires logic - we dont want the release to be triggered until we actually release otherwise the action erroneously attempts to upload a wheel to pypi with a spurious 0.0.1 tag. Additionally the release action publishes documentation to github pages and that **must not** happen until we release. This also simplifies logic in the merge-requires workflow - the test for github.event_name == 'release' did not apparently work. AB#10062
eccles
force-pushed
the
eccles-patch-1
branch
from
3043f27 to
c13efcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix github action
Remove the release requires logic - we dont want the release to be
triggered until we actually release otherwise the action erroneously
attempts to upload a wheel to pypi with a spurious 0.0.1 tag.
Additionally the release action publishes documentation to github pages
and that must not happen until we release.
This also simplifies logic in the merge-requires workflow - the test
for github.event_name == 'release' did not apparently work.
Tested extensively by adding debug statements and watching the release workflow fail badly
many time.
AB#10062