Use trusted publisher and environment #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eccles
force-pushed
the
dev/paul/use-trusted-publisher-to-upload-to-pypi
branch
from
34dedab to
4c1b08d
Compare
Setup PyPi for datatrails-python to use a trusted publisher. Delete any API tokens in PyPi for datatrails-python. In github repo delete PYPI secrets and create an environmant called release that is restricted to the main branch.
eccles
force-pushed
the
dev/paul/use-trusted-publisher-to-upload-to-pypi
branch
from
4c1b08d to
cbe9d7d
Compare
eccles
requested review from
waarg,
robinbryce,
JAG-UK,
j-hartley and
landintrees
landintrees
reviewed
Nov 29, 2024
waarg
reviewed
Nov 29, 2024
eccles
changed the title
waarg
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup PyPi for datatrails-python to use a trusted publisher. Delete any API tokens in PyPi for datatrails-python.
In github repo delete PYPI secrets and create an environmant called release that is restricted to the main branch.
Testing: can only be tested by merging and releasing: if this fails it will be refined and remerged and rereleased. Any wheels so uploaded will be marked as alpha and yanked to prevent access by third parties.