Modify error handling #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } catch (e) { | ||
| if (e instanceof Response400Error || e instanceof InvalidResponseError) { | ||
| throw e; |
There was a problem hiding this comment.
If the response is a 4xx, it means that the requested GraphQL query has some errors, and reconnecting won't help solve the situation. The same kinda applies to InvalidResponseError.. if the server is returning something that's not JSON it probably isn't something that can be solved by retrying. For the latter, maybe we can discuss about it :)
There was a problem hiding this comment.
I've amended the change to only throw on 404s.
There was a problem hiding this comment.
I closed this PR in favour of #2. Let's continue the review there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two callbacks,
onErrorandonEventto improve observability.Attempts are made to recover from more error conditions, to avoid zombie connections that never reach 'connected' state.