Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luaL_ref failures result in leaked memory #6

Closed
daurnimator opened this issue Oct 3, 2016 · 1 comment
Closed

luaL_ref failures result in leaked memory #6

daurnimator opened this issue Oct 3, 2016 · 1 comment
Labels
bug

Comments

@daurnimator
Copy link
Owner

daurnimator commented Oct 3, 2016 •
edited
Loading

If luaL_ref fails, then lua longjmps out of the code, meaning that callback data does not get freed.

Fixing this should require a very different structure for holding references to callback functions.
@daurnimator daurnimator mentioned this issue Oct 3, 2016
Open
@daurnimator daurnimator added the bug label Oct 3, 2016
@daurnimator
Copy link
Owner Author

4e95fff also introduces a ref leak if any functions longjmp out. They should be fixed along with this issue.

daurnimator added a commit that referenced this issue Nov 4, 2017
@daurnimator
src/pending_call.c: Use different style of callback management
aa02a4c 
Related to #6
daurnimator added a commit that referenced this issue Nov 4, 2017
@daurnimator
src/connection.c: Use different style of callback management for VTab…
18caa3b 
…le functions

Related to #6
daurnimator added a commit that referenced this issue Nov 4, 2017
@daurnimator
src/connection.c: Use different style of callback management for wake…
22c8abb 
…up and dispatch functions

Related to #6
daurnimator added a commit that referenced this issue Nov 4, 2017
@daurnimator
src/: Move 'watch' callbacks to new callback management style
56cb917 
Related to #6
daurnimator added a commit that referenced this issue Nov 4, 2017
@daurnimator
src/: Move 'timeout' callbacks to new callback management style
c33ab70 
Related to #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daurnimator