Merge pull request #5 from tonerdo/master

Update fork
daveMueller · Sep 17, 2019 · ef7d0b0 · ef7d0b0
2 parents 45075e1 + 2aa8ed6
commit ef7d0b0
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -41,7 +41,8 @@ After the above command is run, a `coverage.cobertura.json` file containing the
 See [documentation](Documentation/VSTestIntegration.md) for advanced usage.
 
 #### Requirements
-* _You need to be running .NET Core SDK v2.2.300 and above_
+* _You need to be running .NET Core SDK v2.2.300 or newer_
+* _To run fully-featured collectors ([see #110](https://github.com/tonerdo/coverlet/issues/110)) you need to be running  .NET Core SDK v2.2.401 or newer_
 * _You need to reference version 16.1.0 and above of Microsoft.NET.Test.Sdk_
 ```
 <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.1.0" />

diff --git a/eng/azure-pipelines-nightly.yml b/eng/azure-pipelines-nightly.yml
@@ -3,7 +3,7 @@ pool:
 steps:
 - task: UseDotNet@2
   inputs:
-    version: 2.2.300
+    version: 2.2.401
 - powershell:
     .\eng\nightly.ps1 -apiKey $env:APIKEY -source $env:SOURCE
   ignoreLASTEXITCODE: true

diff --git a/src/coverlet.core/Instrumentation/Instrumenter.cs b/src/coverlet.core/Instrumentation/Instrumenter.cs
@@ -76,7 +76,7 @@ public bool CanInstrument()
                         }
                         else
                         {
-                            _logger.LogWarning($"Unable to instrument module: {_module}, embedded pdb without local source files, [{firstNotFoundDocument}]");
+                            _logger.LogVerbose($"Unable to instrument module: {_module}, embedded pdb without local source files, [{firstNotFoundDocument}]");
                             return false;
                         }
                     }
@@ -88,7 +88,7 @@ public bool CanInstrument()
                         }
                         else
                         {
-                            _logger.LogWarning($"Unable to instrument module: {_module}, pdb without local source files, [{firstNotFoundDocument}]");
+                            _logger.LogVerbose($"Unable to instrument module: {_module}, pdb without local source files, [{firstNotFoundDocument}]");
                             return false;
                         }
                     }

diff --git a/test/coverlet.core.tests/Instrumentation/InstrumenterTests.cs b/test/coverlet.core.tests/Instrumentation/InstrumenterTests.cs
@@ -353,7 +353,7 @@ public void SkipEmbeddedPpdbWithoutLocalSource()
             Assert.True(_instrumentationHelper.HasPdb(xunitDll, out bool embedded));
             Assert.True(embedded);
             Assert.False(instrumenter.CanInstrument());
-            loggerMock.Verify(l => l.LogWarning(It.IsAny<string>()));
+            loggerMock.Verify(l => l.LogVerbose(It.IsAny<string>()));
 
             // Default case
             string coverletCoreDll = Directory.GetFiles(Directory.GetCurrentDirectory(), "coverlet.core.dll").First();
@@ -380,7 +380,7 @@ public void SkipPpdbWithoutLocalSource()
             Assert.True(_instrumentationHelper.HasPdb(coverletLib, out bool embedded));
             Assert.False(embedded);
             Assert.False(instrumenter.CanInstrument());
-            loggerMock.Verify(l => l.LogWarning(It.IsAny<string>()));
+            loggerMock.Verify(l => l.LogVerbose(It.IsAny<string>()));
         }
 
         [Fact]

diff --git a/test/coverlet.core.tests/coverlet.core.tests.csproj b/test/coverlet.core.tests/coverlet.core.tests.csproj
@@ -5,6 +5,7 @@
     <TargetFramework>netcoreapp2.0</TargetFramework>
     <IsPackable>false</IsPackable>
     <LangVersion>preview</LangVersion>
+    <NoWarn>$(NoWarn);CS8002</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>