Configuration class for BatchSpanProcessor (open-telemetry#1080)

* Add config class for BatchSpanProcessor * Implement Configuration for BatchSpanProcessor * goJF after rebase
davebarda · Apr 24, 2020 · 3571495 · 3571495
1 parent 6e1c016
commit 3571495
Show file tree

Hide file tree

Showing 7 changed files with 669 additions and 35 deletions.
diff --git a/build.gradle b/build.gradle
@@ -126,6 +126,7 @@ subprojects {
                 junit                : 'junit:junit:4.12',
                 mockito              : 'org.mockito:mockito-core:2.28.2',
                 truth                : 'com.google.truth:truth:1.0.1',
+                system_rules         : 'com.github.stefanbirkner:system-rules:1.19.0', // env and system properties
                 slf4jsimple          : 'org.slf4j:slf4j-simple:1.7.25', // Compatibility layer
                 awaitility           : 'org.awaitility:awaitility:3.0.0', // Compatibility layer
                 testcontainers       : 'org.testcontainers:testcontainers:1.13.0',

diff --git a/exporters/jaeger/src/main/java/io/opentelemetry/exporters/jaeger/JaegerGrpcSpanExporter.java b/exporters/jaeger/src/main/java/io/opentelemetry/exporters/jaeger/JaegerGrpcSpanExporter.java
@@ -232,7 +232,7 @@ public JaegerGrpcSpanExporter build() {
      * @param tracerSdkProvider tracer SDK provider
      */
     public void install(TracerSdkProvider tracerSdkProvider) {
-      BatchSpansProcessor spansProcessor = BatchSpansProcessor.newBuilder(this.build()).build();
+      BatchSpansProcessor spansProcessor = BatchSpansProcessor.create(this.build());
       tracerSdkProvider.addSpanProcessor(spansProcessor);
     }
 

diff --git a/sdk/build.gradle b/sdk/build.gradle
@@ -18,6 +18,8 @@ dependencies {
 
     testAnnotationProcessor libraries.auto_value
 
+    testCompile libraries.system_rules
+
     signature "org.codehaus.mojo.signature:java17:1.0@signature"
     signature "net.sf.androidscents.signature:android-api-level-24:7.0_r2@signature"
 }