Fix an error with continuous subscription #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherDavenport
approved these changes
Apr 28, 2022
Yeah, it would have called xread with the initial offset repeatedly, since the |
|
This is fully binary compatible right? Making sure I'm reading this right I think I can release this as a patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuous subscription was not being updated correctly as it was never getting the offset correctly from the response. (Likely lost during the initial refactor).
Also added a test, which tries to request more records than present eventually timing out. This would originally return repeated records from the beginning as the offsets were never updated.
Also added xrange and xrevrange as a bonus.