Added xreadgroup, xtrim, xclaim, xautoclaim, xpending commands

[Swoorup]

• Adds xreadgroup (mostly same as xread), xtrim commands.
• Updates xgroupcreate such that it allows to specify creation of stream

[ChristopherDavenport]

Is mima off? switching to defaults args I didn't think was binary compatible.

[Swoorup]

Is mima off? switching to defaults args I didn't think was binary compatible.

In build.sbt, the mimaPreviousArtifacts is empty and has comment // Bincompat breaking till next release.

Looks like following will fix the incompatability. Any thoughts? @ChristopherDavenport

  def xgroupcreate[F[_]: RedisCtx](stream: String, groupName: String, startId: String, mkStream: Boolean): F[Status] = {
    val mkStreamFragment = Alternative[List].guard(mkStream).as("MKSTREAM")
    RedisCtx[F].unkeyed(NEL("XGROUP", "CREATE" :: stream :: groupName :: startId :: mkStreamFragment))
  }

  def xgroupcreate[F[_]: RedisCtx](stream: String, groupName: String, startId: String): F[Status] = 
    xgroupcreate(stream, groupName, startId, false)

[ChristopherDavenport]

If you make the current one package private that will work great.

The one you delegate to the new one in.

[Swoorup]

If you make the current one package private that will work great.

The one you delegate to the new one in.

Hmm, it still complains of

 filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("io.chrisdavenport.rediculous.RedisCommands.xgroupcreate")
[error] rediculous: Failed binary compatibility check against io.chrisdavenport:rediculous_2.13:0.3.2! Found 1 potential problems
[error]  * static method xgroupcreate(java.lang.String,java.lang.String,java.lang.String,io.chrisdavenport.rediculous.RedisCtx)java.lang.Object in class io.chrisdavenport.rediculous.RedisCommands does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("io.chrisdavenport.rediculous.RedisCommands.xgroupcreate")

using private[rediculous] def xgroupcreate[F[_]: RedisCtx](stream: String, groupName: String, startId: String): F[Status]

[ChristopherDavenport]

Fairly certain that's normal. Feel free to add the exclusion. Will confirm with @armanbilge just to be double safe.

[armanbilge]

My recommendation would be to leave that method public but deprecated, like so:

@deprecated("x.y.z.", "use ... instead")
def xgroupcreate[F[_]](stream: String, groupName: String, startId: String, redisCtx: RedisCtx[F]): F[Status]

In theory, static methods are not really a concern since they would only be used by hypothetical Java interop. But the bigger problem is that every time you add a filter, it might mask real binary-incompatible changes in the future. Unfortunately MiMa filters are just not fine grained enough, for example to distinguish between static and non-static methods.

[Swoorup]

Done.

[ChristopherDavenport]

How is adding a value to a sealed trait safe? Or is that just source breaking not mima breaking?

My brain is trying to put the pieces together here.

[armanbilge]

@ChristopherDavenport you mean this change? You are right, this is not backwards-compatible. See:

• Warn on adding a type constructor to a sum type lightbend-labs/mima#200

[Swoorup]

But this is I gather, only if pattern matching on the user side? Which seems a rather odd use in this case.

[Swoorup]

@ChristopherDavenport Anything changes required on this?

[ChristopherDavenport]

I think the best way is to just release a new minor. Its limited changes and as you mentioned no one is probably doing this so the only burden is on intermediate libraries.

Are there any other values here we should add?

[ChristopherDavenport]

Answering my own question this looks good.

[Swoorup]

That should be all, I believe.

[Swoorup]

Added xpendingsummary, xclaimsummary, xclaimdetail, xautoclaimsummary, xautoclaimdetail.