Update No Ref Siblings to Use Rolodex #543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove extra spacing between lines Add whitespace to match original file
califlower
force-pushed
the
no-ref-siblings-rolodex
branch
from
dab18cf to
7bc6a72
Compare
daveshanley
approved these changes
Oct 11, 2024
|
@califlower - Would you be able to rebase, I would like to add this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is my first contribution, so if you want something a particular way please let me know! I tried to keep everything as consistent as possible between the changes
No Ref Siblingscomponent to use theRolodexin order to properly traverse all referenced files.idx.FindNodeOrigin(val)instead ofidx.FindNode(key)because using the key returned nil each time.I can add a test for this if needed, but I wasn't sure how to test the
No Ref Siblingsrule for multiple files.Fixes: