Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency maintenance #701

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andersstorhaug
Copy link

@andersstorhaug andersstorhaug commented Feb 4, 2022

Summary of changes:

  • Upgrading packages, most notably rxjs to v7
  • Removing unused packages: tsdx, @vue/reactivity, @types/webpack, cross-env
    • These were all dev dependencies, but, with tsdx specifically now that it's unmaintained, it was constraining package versions
  • Replacing compromised faker package with @faker-js/faker fork

Some other notes:

  • Seems that in later versions of TS, catch errors are typed as any (which makes some sense), so DynamicDataError reflects this
  • The Rx toPromise operator has been replaced with lastValueFrom, see RxJS docs
  • RxJS v7 no longer exports isScheduler, and so, this function has effectively been pulled into expireAfter.ts
  • It seems that later versions of husky have a somewhat long-standing issue with Git GUIs, and I had to bypass commit hooks. I'm not sure if this was a problem before

@github-actions github-actions bot added this to the v0.1.0 milestone Feb 4, 2022
@andersstorhaug andersstorhaug force-pushed the dependency-maintenance branch 2 times, most recently from 805fcb6 to be8f963 Compare February 4, 2022 01:13
@andersstorhaug
Copy link
Author

andersstorhaug commented Feb 4, 2022

As for the Mergify error, I'm not familiar at all but I did find this blog post. It seems the equivalent .mergify.yml could be:

queue_rules:
  - name: default
    method: squash
    conditions: []

pull_request_rules:
  - name: automatic merge when GitHub branch protection passes (others)
    conditions:
      - base=master
      - -author~=^dependabot(|-preview)\[bot\]$
      - 'label=:shipit: merge'
    actions:
        queue:
            name: default
  - name: auto merge github-actions
    conditions:
      - 'label=github-actions'
      - author~=^dependabot(|-preview)\[bot\]$
    actions:
      label:
        add:
          - ':shipit: merge'
  - name: automatic merge when GitHub branch protection passes
    conditions:
      - merged
      - 'label=:shipit: merge'
    actions:
      label:
        remove:
          - ':shipit: merge'
  - name: delete head branch after merge
    conditions:
      - merged
    actions:
      label:
        remove:
          - ':shipit: merge'
      delete_head_branch: {}

- Upgrading packages, most notably `rxjs` to v7
- Removing unused packages: `tsdx`, `@vue/reactivity`, `@types/webpack`
- Replacing compromised `faker` package with `@faker-js/faker` fork
@andersstorhaug
Copy link
Author

@david-driscoll Sorry to @ you, a lot of bot-initiated PRs here so wanted to make sure that you were aware. Any thoughts on reviving this project? I like what has been done here, and perhaps we can get the ball rolling again. Thought that bringing dependencies up to date, esp. with RxJS v7, would be a good start.

@@ -5,7 +5,7 @@ module.exports = {
globals: {
'ts-jest': {
compiler: 'typescript',
tsConfig: {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This casing produces a warning with newer versions of Jest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant