-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency maintenance #701
base: master
Are you sure you want to change the base?
Dependency maintenance #701
Conversation
805fcb6
to
be8f963
Compare
As for the Mergify error, I'm not familiar at all but I did find this blog post. It seems the equivalent queue_rules:
- name: default
method: squash
conditions: []
pull_request_rules:
- name: automatic merge when GitHub branch protection passes (others)
conditions:
- base=master
- -author~=^dependabot(|-preview)\[bot\]$
- 'label=:shipit: merge'
actions:
queue:
name: default
- name: auto merge github-actions
conditions:
- 'label=github-actions'
- author~=^dependabot(|-preview)\[bot\]$
actions:
label:
add:
- ':shipit: merge'
- name: automatic merge when GitHub branch protection passes
conditions:
- merged
- 'label=:shipit: merge'
actions:
label:
remove:
- ':shipit: merge'
- name: delete head branch after merge
conditions:
- merged
actions:
label:
remove:
- ':shipit: merge'
delete_head_branch: {}
|
- Upgrading packages, most notably `rxjs` to v7 - Removing unused packages: `tsdx`, `@vue/reactivity`, `@types/webpack` - Replacing compromised `faker` package with `@faker-js/faker` fork
be8f963
to
a715834
Compare
@david-driscoll Sorry to @ you, a lot of bot-initiated PRs here so wanted to make sure that you were aware. Any thoughts on reviving this project? I like what has been done here, and perhaps we can get the ball rolling again. Thought that bringing dependencies up to date, esp. with RxJS v7, would be a good start. |
@@ -5,7 +5,7 @@ module.exports = { | |||
globals: { | |||
'ts-jest': { | |||
compiler: 'typescript', | |||
tsConfig: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This casing produces a warning with newer versions of Jest.
Summary of changes:
rxjs
to v7tsdx
,@vue/reactivity
,@types/webpack
,cross-env
tsdx
specifically now that it's unmaintained, it was constraining package versionsfaker
package with@faker-js/faker
forkSome other notes:
catch
errors are typed asany
(which makes some sense), soDynamicDataError
reflects thistoPromise
operator has been replaced withlastValueFrom
, see RxJS docsisScheduler
, and so, this function has effectively been pulled intoexpireAfter.ts
husky
have a somewhat long-standing issue with Git GUIs, and I had to bypass commit hooks. I'm not sure if this was a problem before