Allow action summary group duration to be nil #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `duration` field is not included in the .xcresults bundle data when a test group is composed of only tests which crashed during the test run. Requiring `duration` here causes the entire test group parsing to fail.
|
Awesome, looks good to me. Thanks for finding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
durationfield is not included in the.xcresultsbundle data when a test group is composed of only tests which crashed during the test run. Requiringdurationhere causes the entire test group parsing to fail.To reproduce the issue that this fixes, try creating a test suite with a single test that has a
fatalErrorcall. Process the output and you'll see that aSummaryis generated for the test suite, and metrics show 1 run test, 1 failed... but the actual Group (and hence dependent test objects) will not be included in theActionsInvocationRecordreturned bygetInvocationRecord().