Prefer is.null() (and is.na()) over missing()
#354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stops using `missing()` to make functions easier to program with
For backward compatibility
jack-davison
changed the title
is.null() (and is.na()) over missing()
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #353.
In short, it implements a preference for
is.na()andis.null()overmissing()for several arguments in directional analysis functions.Previously, one couldn't recreate the default behaviour of functions like
polarFreq()while still passing an argument to, e.g.,breaks.For example,
polarFreq(mydata, breaks = ...). There was nothing that could be passed tobreaksto recreate the default behaviour. This made it difficult to program withpolarFreq()(e.g., inopenairmaps::freqMap()). There is a more complete example in #353.This PR fixes this issue. Effort has been made to make the fix back-compatible with previous versions of
{openair}.