[Enhancement] Jekyll 4.x compatibility #148
Conversation
|
Really appreciate you sorting this out @cristianocasella! I’ve only just recently got back into Jekyll projects I work on and I find the process of updating gems a little daunting. I’ll check out your branch and see if I can get the in-line css option working 👍 |
|
Really thanks for your effort and this project, really appreciated, great job! |
…end documentation
|
@cristianocasella I've got the inline css option working again, not exactly the same but similar enough. Also put back in the Overall I think this may have to be marked as a major version bump, as in Alembic 4.0, since it's newer compatibility and it will break a few things for people updating. |
|
That’s great, let me know if there is anything else I can do to help.
…On Mon, 3 Aug 2020 at 13:02, David Darnes ***@***.***> wrote:
@cristianocasella <https://github.com/cristianocasella> I've got the
inline css option working again, not exactly the same but similar enough.
Also put back in the jekyll-default-layout gem, I realise you removed it
due to incompatibility but it's needed for many of the pages and existing
users will expect it to just work. Hoping to get this fixed by requesting
the gem to be published here:
benbalter/jekyll-default-layout#12
<benbalter/jekyll-default-layout#12>
Overall I think this may have to be marked as a major version bump, as in
Alembic 4.0, since it's newer compatibility and it will break a few things
for people updating.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#148 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLMNQUMZDRHSWGAKMKJU7TR62KNNANCNFSM4PSORVWQ>
.
|
|
@cristianocasella thanks! Would you be able to give me push access to your repo so I can push my changes? |
|
it should be done!
Il giorno lun 3 ago 2020 alle ore 13:16 David Darnes <
notifications@github.com> ha scritto:
… @cristianocasella <https://github.com/cristianocasella> thanks! Would you
be able to give me push access to your repo so I can push my changes?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#148 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLMNQSJ2WGJHN7CPKTA3ODR62MCFANCNFSM4PSORVWQ>
.
|
|
Thanks @cristianocasella! Got it |
Amends to original Pull Request #148
|
All updated now @cristianocasella, just had to go the long way by making a pull request to your fork and then merge it in. Only things left to do are:
|
|
Great, thanks for everything, finger crossed for a quick update on the default layout plugin |
|
@cristianocasella I've been tipped off that we could remote the default layout plugin entirely if we set defaults in the config for page and post collections. More info here: https://jekyllrb.com/docs/configuration/front-matter-defaults/ Would you mind giving it a go in your fork? If not I'll set up your repo properly on my machine and push to it 😅 |
|
sure, working on it |
Adding default layouts in the config
|
@daviddarnes fixed the config and tested, now the default layouts are in place. |
|
Looks good! Thanks a lot for this work @cristianocasella. Going to merge now, will add some minor tweaks and then submit gem 👍 |
This PR is going to fix #146 adding compatibility to the Jekyll 4.x engine.
Tested with Jekyll 4.1.1
I had to deactivate
css_inlinefeature, it's not working anymore and I'm not been able to fix it, any help is welcomed.