Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky headers are not pushing one another from screen when using grid layout manager. #61

Closed
MartinRajniak opened this issue Apr 6, 2016 · 2 comments

Comments

@MartinRajniak
Copy link

Hi,
I am testing 5.0.0-b5 and found a bug in StickyHeaderHelper#translateHeader() on row 151. You are expecting next potential header on position 1. But if for example I use 3 columns in my grid, you will always get current header until all items in section are off the screen.

So you won't get this nice pushing of one header off the screen by another header.

I was able to reproduce this in your demo app, when I changed span count of grid to 3 and span size of all items except header to 1.

Anyway, thanks for great work.

@davideas davideas added the bug label Apr 6, 2016
@davideas
Copy link
Owner

davideas commented Apr 6, 2016

Hello @MartinRajniak, I've reproduced the issue using the fragment ExpandableSection using 3 for span count and size for non header items.

Indeed, it should enter in the if at line 155 to calculate the translation, but it doesn't.
Logging the item cotent with adapterPos it shows:

SubItem[id=E1S1, title=Sub Item 1 in expandable section]
SubItem[id=E1S2, title=Sub Item 2 in expandable section]
but not the sub Item 3, then it swap the header, so it doesn't see where the section ends
swapHeader newPosition=5
SubItem[id=E2S2, title=Sub Item 2 in expandable section]

I will try to fix it.
Thanks.

@davideas
Copy link
Owner

I think this issue should be resolved, available with the SNAPSHOT of 2017-04-17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants