Support for fully recursive lists (expansion, collapsing, and update) #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 21, 2017 12:25
…item positions will be checked for nested expansion during update.
…e into account recursive expansions at previous subitems.
…h is not necessary since the method already traverses recursively through subitems as expansions occur. Cleaned up comments and removed unused variable.
davideas
approved these changes
Jun 30, 2017
| @@ -4945,7 +4976,7 @@ private RestoreInfo getPendingRemovedItem(T item) { | |||
| * @since 5.0.0-b1 | |||
| */ | |||
| private void createRestoreSubItemInfo(IExpandable expandable, T item) { | |||
| List<T> siblings = getExpandableList(expandable); | |||
| List<T> siblings = getExpandableList(expandable, true); | |||
There was a problem hiding this comment.
I think this call should return only direct siblings, so the parameter should be false.
Because when restoring deleted items in restoreDeletedItems(), the position is relative to the parent when addSubItem() is called there.
| for(int index = 0; index < subPosition; index++) { | ||
| T tempSubItem = subItems.get(index); | ||
| // Check whether item is also expandable, and expanded | ||
| if(this.isExpandable(tempSubItem) && ((IExpandable) tempSubItem).isExpanded()) { |
There was a problem hiding this comment.
When isExpanded() is called isExpandable() is checked internally too.
| // Add the current subitem | ||
| subItems.add(subItem); | ||
| // If expandable, expanded, and of non-zero size, recursively add sub-subItems | ||
| if(this.isExpandable(subItem) && |
There was a problem hiding this comment.
Same here, isExpandable() can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code added to support full recursion, returning all nested subchildren that are expanded and thus appropriate counts for expansion and collapse.