FT: signature hint close and toggle functions #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lua/scnvim/signature.lua
Outdated
| @@ -101,7 +102,7 @@ local function show_signature(object) | |||
| local signature = res:match '%((.+)%)' | |||
| if signature then | |||
| if float then | |||
| lsp_util.open_floating_preview({ signature }, 'supercollider', float_conf) | |||
| _, hint_winid = lsp_util.open_floating_preview({ signature }, 'supercollider', float_conf) | |||
There was a problem hiding this comment.
perhaps
local _, id = lsp_util.open_floating_preview({ signature }, 'supercollider', float_conf)
hint_winid = id
just to keep the linter happy
|
Thanks for the PR, works great! I hope the comment I left you will resolve the linter error, i'll merge this once the CI has passed. |
|
Nice! Thanks @daveriedstra and @davidgranstrom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functions to
scnvim.signatureto close and toggle the signature hint popup per discussion on #238.