Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jedi-vim issue #385: extra '=' sign for params #721

Conversation

StephenHesperus
Copy link

jedi-vim issue #385:
davidhalter/jedi-vim#385
Completion of function arguments get an extra = sign

jedi-vim issue davidhalter#385:
  davidhalter/jedi-vim#385
  Completion of function arguments get an extra = sign
@davidhalter
Copy link
Owner

I appreciate the effort! While this is solving the problem in jedi-vim, this is clearly not solving the issue completely. We want the = to be there in some cases (when it's part of an argument). I'm pretty sure the tests would also be failing (if not for the issue on master).

Also please read CONTRIBUTING.md, make pull requests to the dev branch.

@StephenHesperus
Copy link
Author

Thanks for the response! Sorry for the inconvenience.

As of the '=' sign, I think it's very nice if it's there when we need it, but right now, I do appreciate it if it just gives me the parameter name correctly, I can add the '=' sign by myself when I need it 😄

And thank you for writing jedi and jedi-vim as such awesome tools! 👍

@davidhalter
Copy link
Owner

As of the '=' sign, I think it's very nice if it's there when we need it, but right now, I do appreciate it if it just gives me the parameter name correctly, I can add the '=' sign by myself when I need it 😄

I can understand this, but this has worked once. It's a bug that is definitely fixable by checking if you're inside a function definition. I'm pretty sure it will not work as it once did, but it will be better.

Just check the tests, if those are almost passing you would be on a good way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants