Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Do not use sys.version_info with _get_venv_sitepackages #829

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jan 15, 2017

Those might differ, e.g. when Neovim's host is Python 3.6, but the
virtualenv is 3.5.2.

Those might differ, e.g. when Neovim's host is Python 3.6, but the
virtualenv is 3.5.2.
@blueyed
Copy link
Contributor Author

blueyed commented Jan 15, 2017

There should be some warning being logged in that case probably.
Would it be possible for tools like jedi-vim then to get notified about it / display it?

@davidhalter
Copy link
Owner

I actually really don't want to add this, because it leads to extremely weird segfaults in some situations (like using a library like QT with the wrong Python version). I'm sorry, but it would be adding additional bugs to Jedi (that are even more annoying).

#385 is still highly relevant and I plan to work on that ASAP. However it might still take a while :( It's just way to much work such a library.

@JakobGM
Copy link

JakobGM commented Jul 24, 2017

@davidhalter Would you consider adding this behind an experimental flag?

Unfortunately, this makes jedi-vim unusable with Python 3.6, at the moment. And this silent 'bug' took me way too long to debug.

As @blueyed suggested, some sort of logging mechanism would make it possible to alert the user of the fact that autocompletions don't work for non-Python3.5 versions.

Thanks!

@blueyed
Copy link
Contributor Author

blueyed commented Jul 24, 2017

makes jedi-vim unusable with Python 3.6

Not really.. it depends on the version(s) you are using.
I can only recommend Neovim again, which allows for more flexibility with regard to the Python version(s) you are using/mixing.

But I agree that it makes it more difficult to figure out, especially since there is no feedback. IIRC it took me quite a while myself back when I've created this PR.

@JakobGM
Copy link

JakobGM commented Jul 24, 2017

@blueyed Yeah, unusable is probably the wrong word here. For the moment, I have applied the patch manually, and will see how these segfaults will affect my normal workflow (if at all?).

Will do the research on NeoVim as a suitable permanent replacement as well. Thanks!

@hbutau
Copy link

hbutau commented Nov 19, 2017

I have been trying neovim with python3.6 and jedi-vim just doesnt work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants