Fix instance docstring #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhalter
reviewed
Jul 13, 2017
jedi/evaluate/instance.py
Outdated
| @@ -24,6 +24,7 @@ def __init__(self, evaluator, parent_context, class_context, var_args): | |||
| super(AbstractInstanceContext, self).__init__(evaluator, parent_context) | |||
| # Generated instances are classes that are just generated by self | |||
| # (No var_args) used. | |||
| self.tree_node = class_context.tree_node | |||
There was a problem hiding this comment.
Hmm, thanks for the test and fix. However I'm not sure I like this here. If anything I would have probably moved that assignment to jedi.evaluate.instance.TreeInstance. Would that make sense for you?
There was a problem hiding this comment.
Yes, I moved it to TreeInstance.
micbou
force-pushed
the
fix-instance-docstring
branch
from
f7fbf41
to
160510f
Compare
|
Thanks man, good stuff! |
This was referenced Aug 10, 2017
zzbot
added a commit
to vheon/JediHTTP
that referenced
this pull request
Aug 20, 2017
[READY] Update Jedi to latest commit Jedi master branch now includes davidhalter/jedi#941 and davidhalter/jedi#942 fixes, and successfully passes ycmd tests. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/vheon/jedihttp/36) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jedi always returns an empty docstring for an instance. For example, the following code:
returns nothing while it should output
Docstring of `TestClass`.. It's a regression introduced by commit 7ca6257.This PR fixes the regression and add two docstring tests: one with a class and another with an instance.
This change is