Code review

davidjbradshaw · Sep 11, 2024 · 349b05f · 349b05f
1 parent 6f63bc0
commit 349b05f
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/packages/core/index.js b/packages/core/index.js
@@ -126,7 +126,9 @@ function iframeListener(event) {
     // the message format would break backwards compatibility.
     const retCode = messageData.type in { true: 1, false: 1, undefined: 1 }
 
-    if (retCode) log(iframeId, 'Ignoring init message from meta parent page')
+    if (retCode) {
+      log(iframeId, 'Ignoring init message from meta parent page')
+    }
 
     return retCode
   }
@@ -743,11 +745,11 @@ function setSize(messageData) {
   function setDimension(dimension) {
     const size = `${messageData[dimension]}px`
     messageData.iframe.style[dimension] = size
-    log(iframeId, `IFrame (${iframeId}) ${dimension} set to ${size}`)
+    log(id, `IFrame (${id}) ${dimension} set to ${size}`)
   }
 
-  const iframeId = messageData.id
-  const { sizeHeight, sizeWidth } = settings[iframeId]
+  const { id } = messageData
+  const { sizeHeight, sizeWidth } = settings[id]
 
   if (sizeHeight) setDimension('height')
   if (sizeWidth) setDimension('width')