Use setTimeout(0) on events with void return type

davidjbradshaw · Aug 28, 2024 · 85f7bd5 · 85f7bd5
1 parent 8a3b4ac
commit 85f7bd5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/packages/child/index.js b/packages/child/index.js
@@ -156,7 +156,7 @@ function iframeResizerChild() {
 
     sendTitle()
     initEventListeners()
-    onReady()
+    setTimeout(onReady)
 
     log('Initialization complete')
     log('---')
@@ -1285,7 +1285,7 @@ The <b>size()</> method has been deprecated and replaced with  <b>resize()</>. U
         const msgBody = getData()
         log(`PageInfo received from parent: ${msgBody}`)
         if (onPageInfo) {
-          onPageInfo(JSON.parse(msgBody))
+          setTimeout(() => onPageInfo(JSON.parse(msgBody)))
         } else {
           // not expected, so cancel more messages
           sendMsg(0, 0, 'pageInfoStop')
@@ -1297,7 +1297,7 @@ The <b>size()</> method has been deprecated and replaced with  <b>resize()</>. U
         const msgBody = getData()
         log(`ParentInfo received from parent: ${msgBody}`)
         if (onParentInfo) {
-          onParentInfo(Object.freeze(JSON.parse(msgBody)))
+          setTimeout(onParentInfo(Object.freeze(JSON.parse(msgBody))))
         } else {
           // not expected, so cancel more messages
           sendMsg(0, 0, 'parentInfoStop')

diff --git a/packages/core/index.js b/packages/core/index.js
@@ -676,13 +676,13 @@ function chkEvent(iframeId, funcName, val) {
   if (settings[iframeId]) {
     func = settings[iframeId][funcName]
 
-    if (typeof func === 'function') {
-      retVal = func(val)
-    } else {
+    if (typeof func === 'function')
+      if (funcName === 'onClose' || funcName === 'onScroll') retVal = func(val)
+      else setTimeout(() => func(val))
+    else
       throw new TypeError(
         `${funcName} on iFrame[${iframeId}] is not a function`,
       )
-    }
   }
 
   return retVal