Fix: jQuery wrapper startup

davidjbradshaw · Aug 22, 2024 · d3cad41 · d3cad41
1 parent 35337e6
commit d3cad41
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/packages/core/index.js b/packages/core/index.js
@@ -880,8 +880,8 @@ export default (options) => (iframe) => {
     }
 
     if (iframeId === '' || !iframeId) {
-      // eslint-disable-next-line no-multi-assign
-      iframe.id = iframeId = newId()
+      iframeId = newId()
+      iframe.id = iframeId
       setLogEnabled((options || {}).log)
       log(iframeId, `Added missing iframe ID: ${iframeId} (${iframe.src})`)
     }

diff --git a/packages/jquery/plugin.js b/packages/jquery/plugin.js
@@ -18,8 +18,9 @@ switch (true) {
   default:
     window.jQuery.fn.iframeResize = function (options) {
       const connectWithOptions = connectResizer(options)
+      const init = (i, el) => connectWithOptions(el)
 
-      return this.filter('iframe').each(connectWithOptions).end()
+      return this.filter('iframe').each(init).end()
     }
 
     window.jQuery.fn.iFrameResize = function (options) {

diff --git a/spec/initJQuerySpec.js b/spec/initJQuerySpec.js
@@ -2,6 +2,16 @@ define(['iframeResizerJquery', 'jquery'], (iframeResize, $) => {
   describe('iFrame init(jQuery)', () => {
     loadIFrame('iframe600.html')
 
+    it('is callable', () => {
+      const iframe = $('iframe').iframeResize({
+        license: 'GPLv3',
+        log: true,
+        warningTimeout: 100,
+      })[0]
+
+      tearDown(iframe)
+    })
+
     xit('should create iFrameResizer object', (done) => {
       $('iframe').iframeResize({
         license: 'GPLv3',