build: lint JS configuration files #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 122 122
Lines 623 623
Branches 76 76
=======================================
Hits 598 598
Misses 19 19
Partials 6 6 ☔ View full report in Codecov by Sentry. |
|
🚀 This pull request is included in v2.63.2. See v2.63.2 for release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moar linter additions. In this case, adding JavaScript configuration files (ESLint config file (:inception:) and Karma configuration files) as files to lint.
To achieve that, ESLint recommended rules are applied to JS files in root of repo.
Fixes issues about
__dirnameand__filename. Adds Node.js globals.Renames boolean constant about using typed rules or not. This wasn't linter-triggered, as there are no types in the ESLint config file as it is a
*.mjs, not TS file. Using TypeScript for ESLint configuration files is enabled behind a flag + requires an extra dependency. So keeping that file as JavaScript to avoid introducing complexity.