Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use signals in chipped content component #875

Merged

Conversation

davidlj95
Copy link
Owner

One of the components that wasn't migrated was chipped content component. Let's migrate it!

Also migrates the internals of it to use signals.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (aa587f6) to head (1dc5df2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
+ Coverage   95.94%   95.95%   +0.01%     
==========================================
  Files         123      123              
  Lines         616      618       +2     
  Branches       70       70              
==========================================
+ Hits          591      593       +2     
  Misses         19       19              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidlj95 davidlj95 merged commit babd22b into main Nov 27, 2024
15 checks passed
@davidlj95 davidlj95 deleted the stacked/refactor-use-signals-in-chipped-content-component branch November 27, 2024 19:10
Copy link

🚀 This pull request is included in v2.63.2. See v2.63.2 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant