Fix more opt log output artifacts #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with log output lines like these (observed in Node 10.3 on Arch Linux):
```
INLINE (pp.expect) id{43--- FUNCTION SOURCE (/home/goto-bus-stop/Code/goto-bus-stop/dash-ast/node_modules/acorn/dist/acorn.js:isKeyword) id{45,-1} start{27997} ---
INLINE (pp$8.curContext) id{54,3} AS 3--- FUNCTION SOURCE (/home/goto-bus-stop/Code/goto-bus-stop/dash-ast/node_modules/acorn/dist/acorn.js:pp$5.enterLexicalScope) id{56,-1} start{108848} ---
INLINE (has) id{73,2} AS 2 AT <--- FUNCTION SOURCE (/home/goto-bus-stop/Code/goto-bus-stop/dash-ast/bench/index.js:enter) id{75,-1} start{1141} ---
```
Previously, we loosened the FUNCTION SOURCE check so we would detect it
starting in the middle of another function. This issue occurs when a
FUNCTION SOURCE block starts in the middle of an INLINE () line.
When parsing an INLINE () line, this patch then also does the FUNCTION
SOURCE () check on whatever is left over.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with log output lines like these (observed in Node 10.3 on Arch Linux):
Previously, we loosened the FUNCTION SOURCE check so we would detect it
starting in the middle of another function. This issue occurs when a
FUNCTION SOURCE block starts in the middle of an INLINE () line.
When parsing an INLINE () line, this patch then also does the FUNCTION
SOURCE () check on whatever is left over.
Hopefully this is all we need to fix the flakiness on Circle in Flame!