Skip redirecting stdout for Worker threads #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Feb 23, 2019
lib/preload/redir-stdout.js
Outdated
| @@ -1,6 +1,11 @@ | |||
| 'use strict' | |||
| const net = require('net') | |||
|
|
|||
| try { | |||
| // Skip redirecting stdout in Worker threads. | |||
| if (!require('worker_threads').isMainThread) return; | |||
There was a problem hiding this comment.
Lint is failing. Would you mind adding an exception?
There was a problem hiding this comment.
@mcollina Ugh, just seeing that … since this is a parsing error for the linter, not a linter error, I’m not sure there’s a way to add an exception…?
I’ve worked around this the awkward way, wrapping the rest of the file in if (!isWorker). I hope that’s okay?
This breaks running 0x with Workers, because the internal stdio implementation for Workers currently relies on `process.stdout` being the originally provided object.
addaleax
force-pushed
the
no-redir-on-worker
branch
from
3fdb1c4
to
3dd24c4
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks running 0x with Workers, because the internal stdio
implementation for Workers currently relies on
process.stdoutbeing the originally provided object.