Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: add on-port check when kernel-tracing #265

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

RafaelGSS
Copy link
Contributor

Reference: https://github.com/clinicjs/node-clinic-flame/issues/171.

I haven't found an valid approach to pipe between a non-nodejs process. To summarize the problem:

When no kernel-tracing:

  • Root process spawn a new Node.js process
  • The communication happens using a new fd (created using the stdio option).

When kernel-tracing:

  • Root process spawn a non-nodejs process that spawn a nodejs process (nodejs -> linux_perf -> nodejs)
  • So, the communication between the root process and nodejs doesn't work.

The best option so far is improving the UX by throwing an error when both options are used together, instead quitting silently

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 6695f19 into davidmarkclements:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants