Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphql_object! is deprecated #55

Closed
davidpdrsn opened this issue Jul 21, 2019 · 1 comment
Closed

graphql_object! is deprecated #55

davidpdrsn opened this issue Jul 21, 2019 · 1 comment
Labels
in progress

Comments

@davidpdrsn
Copy link
Owner

We should switch to the new object proc macro. I've skimmed the docs and it doesn't seem like it'll be that much work https://docs.rs/juniper_codegen/0.13.0/juniper_codegen/attr.object.html
davidpdrsn added a commit that referenced this issue Sep 21, 2019
@davidpdrsn
Remove use of juniper::graphql_object!
e37532c 
Fixes #55

This isn't complete yet. This patch currently removes support for having
descriptions on field arguments. That is because getting those to work
[requires funky stuff][funky] in the juniper proc macro invocation.

While it could totally be made to work I would rather wait since it
requires a bit of refactoring and since it should work seamlessly once
[RFC 2564](rust-lang/rust#60406) is stable,
which seems to happen in 1.39.

[funky]: https://docs.rs/juniper_codegen/0.13.2/juniper_codegen/attr.object.html#customization-documentation-renaming-
davidpdrsn added a commit that referenced this issue Sep 21, 2019
@davidpdrsn
Remove use of juniper::graphql_object!
947e940 
Fixes #55

This isn't complete yet. This patch currently removes support for having
descriptions on field arguments. That is because getting those to work
[requires funky stuff][funky] in the juniper proc macro invocation.

While it could totally be made to work I would rather wait since it
requires a bit of refactoring and since it should work seamlessly once
[RFC 2564](rust-lang/rust#60406) is stable,
which seems to happen in 1.39.

[funky]: https://docs.rs/juniper_codegen/0.13.2/juniper_codegen/attr.object.html#customization-documentation-renaming-
davidpdrsn added a commit that referenced this issue Sep 21, 2019
@davidpdrsn
Remove use of juniper::graphql_object!
60735f8 
Fixes #55

This isn't complete yet. This patch currently removes support for having
descriptions on field arguments. That is because getting those to work
[requires funky stuff][funky] in the juniper proc macro invocation.

While it could totally be made to work I would rather wait since it
requires a bit of refactoring and since it should work seamlessly once
[RFC 2564](rust-lang/rust#60406) is stable,
which seems to happen in 1.39.

[funky]: https://docs.rs/juniper_codegen/0.13.2/juniper_codegen/attr.object.html#customization-documentation-renaming-
davidpdrsn added a commit that referenced this issue Sep 21, 2019
@davidpdrsn
Remove use of juniper::graphql_object!
8dd9dd4 
Fixes #55

This isn't complete yet. This patch currently removes support for having
descriptions on field arguments. That is because getting those to work
[requires funky stuff][funky] in the juniper proc macro invocation.

While it could totally be made to work I would rather wait since it
requires a bit of refactoring and since it should work seamlessly once
[RFC 2564](rust-lang/rust#60406) is stable,
which seems to happen in 1.39.

[funky]: https://docs.rs/juniper_codegen/0.13.2/juniper_codegen/attr.object.html#customization-documentation-renaming-
@davidpdrsn davidpdrsn mentioned this issue Sep 21, 2019
Closed
@davidpdrsn
Copy link
Owner Author

This landed in #122.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove use of deprecated juniper::graphql_object! davidpdrsn/juniper-from-schema
1 participant
@davidpdrsn