Skip to content

Commit

Permalink
- fixes a bug where auto close issues would be too eager (OAI#3453)
Browse files Browse the repository at this point in the history
  • Loading branch information
baywet authored Nov 16, 2023
1 parent b415dd7 commit 6627c32
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion scripts/close-no-recent.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ foreach($oldIssue in $oldIssues) {
$lastLabelEventDate = [datetime]::Parse($lastLabelEvent.created_at)
if ($lastCommentDate -gt $lastLabelEventDate) {
gh issue edit $oldIssue.number --remove-label "$Env:NO_RECENT_ACTIVITY_LABEL" --remove-label "$Env:NEEDS_AUTHOR_FEEDBACK_LABEL" --add-label "$Env:NEEDS_ATTENTION_LABEL"
} elseif (($lastCommentDate - $lastLabelEventDate) -le $inactivityDelay) {
} elseif (($lastLabelEventDate - $lastCommentDate) -ge $inactivityDelay) {
gh issue close $oldIssue.number -r "not planned"
}
}
2 changes: 1 addition & 1 deletion scripts/label-no-recent.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ foreach($oldIssue in $oldIssues) {
$lastLabelEventDate = [datetime]::Parse($lastLabelEvent.created_at)
if ($lastCommentDate -gt $lastLabelEventDate) {
gh issue edit $oldIssue.number --remove-label "$Env:NO_RECENT_ACTIVITY_LABEL" --remove-label "$Env:NEEDS_AUTHOR_FEEDBACK_LABEL" --add-label "$Env:NEEDS_ATTENTION_LABEL"
} elseif (($lastCommentDate - $lastLabelEventDate) -le $inactivityDelay) {
} elseif (($lastLabelEventDate -$lastCommentDate) -ge $inactivityDelay) {
gh issue edit $oldIssue.number --add-label "$Env:NO_RECENT_ACTIVITY_LABEL" --remove-label "$Env:NEEDS_ATTENTION_LABEL"
gh issue comment $oldIssue.number -b "$Env:NO_RECENT_ACTIVITY_COMMENT"
}
Expand Down

0 comments on commit 6627c32

Please sign in to comment.