Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added provider.getLogs fn #128

Merged
merged 24 commits into from
May 26, 2022
Merged

✨ Added provider.getLogs fn #128

merged 24 commits into from
May 26, 2022

Conversation

arimgibson
Copy link
Contributor

@arimgibson arimgibson commented May 22, 2022

Closes #59 πŸŽ‰

  • Added getLogs fn
  • Added tests against ethers
  • Added tests against web3.js
  • Added inline documentation for getLogs
  • Added cleanLogs class util fn
  • Updated cleanTransactionReceipt class util fn to use cleanLogs

@vercel
Copy link

vercel bot commented May 22, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
essential-eth βœ… Ready (Inspect) Visit Preview May 26, 2022 at 10:51PM (UTC)

@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

Merging #128 (337e8b9) into master (b5c0e24) will increase coverage by 0.38%.
The diff coverage is 97.87%.

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   85.80%   86.19%   +0.38%     
==========================================
  Files          37       38       +1     
  Lines         902      927      +25     
  Branches      259      265       +6     
==========================================
+ Hits          774      799      +25     
  Misses        113      113              
  Partials       15       15              
Impacted Files Coverage Ξ”
src/classes/utils/fetchers.ts 93.33% <ΓΈ> (ΓΈ)
src/index.ts 100.00% <ΓΈ> (ΓΈ)
src/classes/utils/clean-log.ts 95.23% <95.23%> (ΓΈ)
src/classes/utils/clean-transaction-receipt.ts 86.20% <100.00%> (-3.80%) ⬇️
src/logger/package-version.ts 100.00% <100.00%> (ΓΈ)
src/providers/BaseProvider.ts 100.00% <100.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 9da0c9f...337e8b9. Read the comment docs.

Copy link
Owner

@dawsbot dawsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few small comments and merge conflicts need to be resolved.

@dawsbot dawsbot merged commit df0450a into master May 26, 2022
@dawsbot dawsbot deleted the feature/getLogs branch May 26, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add provider.getLogs fn
2 participants