-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧪 Added testing for bytes
functions imported from ethers.js
#134
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
+ Coverage 86.17% 90.71% +4.53%
==========================================
Files 38 38
Lines 926 926
Branches 265 265
==========================================
+ Hits 798 840 +42
+ Misses 113 76 -37
+ Partials 15 10 -5
Continue to review full report at Codecov.
|
@@ -17,7 +17,7 @@ export type Bytes = ArrayLike<number>; | |||
* @example | |||
* '0x123' | |||
*/ | |||
// export type BytesLike = Bytes | string | number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧼 Great cleanup
import { utils as ethers } from 'ethers'; | ||
import { hexConcat } from '../../bytes'; | ||
|
||
describe('utils.hexConcat', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠 This is great testing style
Closes #103
hexConcat()
functionhexDataLength()
functionhexStripZeros()
functionhexValue()
functionisBytesLike()
functionisHexString()
functionstripZeros()
functionzeroPad()
function