-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add shared validateHex
function
#70
Closed
Closed
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
68f3345
:sparkles: Added validateHex function
arimgibson de4a5e6
:arrow-up: Packages changed by precommit script
arimgibson a80a55c
:arrow_up: Packages changed by precommit script
arimgibson 26cc391
Merge branch 'feature/validateHex' of github.com:earnifi/essential-et…
arimgibson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { validateType } from './validate-type'; | ||
|
||
export function validateHex(data: string | number): string { | ||
validateType(data, ['string', 'number']); | ||
if (typeof data === 'string') { | ||
if (!data.startsWith('0x') || data.length % 2) | ||
throw new Error( | ||
`Expected a hex string or number (in any format). Consider prepending this string with '0x' to indicate a hex string. Received value: ${data}`, | ||
); | ||
else return data; | ||
} | ||
return `0x${data.toString(16)}`; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good idea, but this function is not used anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite yet, eventually I want to use it in
hexZeroPad
andhexDataSlice
. I've had to write the same code in both functions to parse both strings and numbers, and then return a standard hex string prefixed with0x
I thought it'd stay as a draft PR, think it got changed to just a regular one when I requested the review. Sorry!