Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy ethers bytes fns #76

Merged
merged 4 commits into from
Apr 18, 2022
Merged

Copy ethers bytes fns #76

merged 4 commits into from
Apr 18, 2022

Conversation

dawsbot
Copy link
Owner

@dawsbot dawsbot commented Apr 17, 2022

Adds

  • arrify
  • hexDataSlice
  • hexlify
  • More

Closes #29
Closes #78

@vercel
Copy link

vercel bot commented Apr 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
essential-eth ✅ Ready (Inspect) Visit Preview Apr 18, 2022 at 8:40PM (UTC)

@dawsbot dawsbot mentioned this pull request Apr 18, 2022
@dawsbot dawsbot changed the title hexDataSlice copy in from ethers Copy ethers bytes fns Apr 18, 2022
@@ -0,0 +1,2 @@
// Generated by genversion.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now required in the codebase because we are logging the ethers version on errors thrown via the new logger

`${message} (argument="${arg}" value=${value}, version=essential-eth@${this.packageVersion})`,
);
}
public checkSafeUint53(value: number, message = 'value not safe'): void {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied in from ethers as-well

Copy link
Contributor

@arimgibson arimgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dawsbot dawsbot merged commit 3068006 into master Apr 18, 2022
@dawsbot dawsbot deleted the hexDataSlice branch April 18, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

utils fn arrayify Add hexDataSlice function
2 participants