Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line break in the corner #1001

Open
MRJCrunch opened this issue Aug 30, 2023 · 4 comments
Open

Line break in the corner #1001

MRJCrunch opened this issue Aug 30, 2023 · 4 comments
Labels
bug Something isn't working complete
Milestone

Comments

@MRJCrunch
Copy link

Environments

  • Framework name: N/A
  • Framework version: N/A
  • Moveable Component version: 0.51.1

Description

I want to change line thickness from 1px to 2px but after this style change I see a line break in the corner

.moveable-line.moveable-direction {
  height: 2px;
}
image image

How can I avoid it?

@SidIcarus
Copy link

You'll have to modify the width/positioning of the lines to be +x/-x, where x is the height delta.

@daybrush daybrush added this to the 0.51.3 milestone Oct 4, 2023
@daybrush daybrush added bug Something isn't working WIP-complete and removed checking labels Oct 4, 2023
daybrush added a commit that referenced this issue Oct 4, 2023
@daybrush
Copy link
Owner

daybrush commented Oct 28, 2023

@SidIcarus

  • croact-moveable 0.8.0
  • @moveable/helper 0.1.3
  • lit-moveable 0.29.0
  • moveable 0.52.0
  • preact-moveable 0.54.0
  • react-moveable 0.55.0
  • svelte-moveable 0.44.0
  • vue-moveable 2.0.0-beta.86
  • vue3-moveable 0.27.0
  • ngx-moveable 0.49.0

moveable' s new version is released.
Added line size calculation.

@MRJCrunch
Copy link
Author

@daybrush thanks for the fix! It works well for 1px lines, but we set the height of rendering lines to 2px and it has a little break.

.moveable-line.moveable-direction {
    height: 2px !important;
 }

Can we fix it somehow?

@daybrush
Copy link
Owner

@daybrush

Because this calculates and sets CSS, it is difficult to support the problem of broken corners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working complete
Projects
None yet
Development

No branches or pull requests

3 participants