Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for Gitea git provider #194

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Mar 13, 2024

Support for Gitea git provider

Description

Adds support for self-hosted Gitea instances and public Codeberg instance.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Signed-off-by: Lauris BH <lauris@nix.lv>
@lafriks lafriks requested review from a team as code owners March 13, 2024 21:19
@idagelic
Copy link
Member

Great work on this contribution! I just tested out Codeberg and it worked perfectly. I'll get to setting up a Gitea installation tomorrow and give more feedback. Thank you

@lafriks
Copy link
Contributor Author

lafriks commented Mar 14, 2024

For testing purposes you can use https://try.gitea.io

@Tpuljak
Copy link
Member

Tpuljak commented Mar 14, 2024

@lafriks amazing work on this!

I'm try out Gitea but I can't seem to get the token right.

I've created a token via their API but the scopes are empty. When I attempt to create a token with "scopes": ["repo", "user"], I get the following error:

{
    "message": "invalid access token scope provided: invalid access token scope: user",
    "url": "https://try.gitea.io/api/swagger"
}

It would be great to add even more info in the description of adding the provider for Gitea to eliminate this sort of mistake from our users.

I suggest creating an map of descriptions that has a key of the provider ID so we can just do, for example, descriptions[provider.Id].

@lafriks
Copy link
Contributor Author

lafriks commented Mar 14, 2024

In Gitea you can actually use the UI (same as in codeberg)

@Tpuljak
Copy link
Member

Tpuljak commented Mar 14, 2024

In Gilea you can actually use the UI (same as in codeberg)

@lafriks you're right 😅

My bad on that one. No need for a more detailed description. Gitea users will know that.

Everything looks great!

@idagelic idagelic merged commit acf94d5 into daytonaio:main Mar 14, 2024
@lafriks lafriks deleted the feat/gitea branch March 14, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants