fix(chip): remove aria-hidden to expose label in a11y tree #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaskuske
requested review from
mfranzke,
nmerget,
dkolba and
annsch
as code owners
jonaskuske
force-pushed
the
fix-chip-a11y
branch
from
a3716ca to
88345ab
Compare
mfranzke
changed the base branch from
main
to
2709-refactor-adapt-changes-out-of-release-300-by-db-ui-core
mfranzke
approved these changes
Aug 6, 2024
…-core' into fix-chip-a11y
mfranzke
merged commit cab0794
into
db-ui:2709-refactor-adapt-changes-out-of-release-300-by-db-ui-core
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See db-ui/core#890