Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to get facebook-ads working on Stitch + BigQuery #1

Merged
merged 4 commits into from
Apr 23, 2019
Merged

Fixes to get facebook-ads working on Stitch + BigQuery #1

merged 4 commits into from
Apr 23, 2019

Conversation

Ken-Lo
Copy link
Collaborator

@Ken-Lo Ken-Lo commented Apr 23, 2019 •
edited
Loading

There were three changes required to get this working on Stitch + BigQuery:

  1. Changed ::date typecast to use dbt_utils.date_trunc()
  2. Rather than using __ (double underscore) to refer to nested fields, using a nested field macro instead
  3. Use stitch_base_table macro as Stitch is append-only on BigQuery

@Ken-Lo Ken-Lo requested a review from DylanBaker April 23, 2019 14:07
@Ken-Lo Ken-Lo changed the title Fixes for BigQuery Fixes to get facebook-ads working on BigQuery Apr 23, 2019
@Ken-Lo Ken-Lo marked this pull request as ready for review April 23, 2019 15:00
@Ken-Lo Ken-Lo changed the title Fixes to get facebook-ads working on BigQuery Fixes to get facebook-ads working on Stitch + BigQuery Apr 23, 2019
DylanBaker
DylanBaker approved these changes Apr 23, 2019
View reviewed changes
Copy link

@DylanBaker DylanBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 This looks great to me @Ken-Lo

@Ken-Lo Ken-Lo merged commit bf18bdd into master Apr 23, 2019
@Ken-Lo Ken-Lo deleted the fixes-for-bq branch April 23, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanBaker DylanBaker DylanBaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ken-Lo @DylanBaker