fix low polarity wrong value for hw_reset deassert and seek(0) before reading sysfs #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarashinvd
force-pushed
the
dbarashi_indep_mode_fix_hwreset
branch
from
6b25da9
to
c68c1b3
Compare
noaOrMlnx
approved these changes
Dec 27, 2023
sysfs returns empty upon plug out cable
dbarashinvd
force-pushed
the
dbarashi_indep_mode_fix_hwreset
branch
from
c68c1b3
to
28ee46f
Compare
dbarashinvd
pushed a commit
that referenced
this pull request
Mar 14, 2024
…#17365) - Why I did it Mellanox MSN2410 platforms have a non-functional error log: "ERR pmon#sensord: Error getting sensor data: dps460/#10: Can't read". This error is because of a firmware issue with some PSU, we are not able to upgrade the FW online. Since there is no functional impact, this error log can be ignored safely - How I did it Add a new rsyslog rule to the rsyslog-container.conf.j2, if the docker name is pmon and the platform name matches, the new rule will be inserted into the docker rsyslogd.conf - How to verify it run regression on the MSN2410 platform to make the error log will not be printed to the syslog. Signed-off-by: Kebo Liu <kebol@nvidia.com>
dbarashinvd
pushed a commit
that referenced
this pull request
Mar 14, 2024
…buf (sonic-net#17521) * [submodule]: Update submodule sonic-swss/sonic-dash-api/protobuf (sonic-net#17413) 1. Protobuf 3.21 has been released in the Debian bookworm 2. Update submodule sonic-swss and sonic-dash-api because they include related updates. - Microsoft ADO **(number only)**: 1. In the protobuf.mk, If it isn't bullseye, ignore to compile the protobuf package 2. Move sonic-swss commits: ``` fd852084 (HEAD, origin/master, origin/HEAD) [dashrouteorch]: Rename dash route namespace (sonic-net#2966) ``` 3. Move sonic-dash-api and move build chain to its submodule ``` d4448c7 (HEAD, origin/master, origin/HEAD, master) [azp]: Add multi-platform artifacts (#11) 8a5e5cc [debian]: Add debian package (#10) d96163a [misc]: Add dash utils and its tests (#9) ``` Signed-off-by: Ze Gan <ganze718@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
fix low polarity wrong value for hw_reset deassert as part of power_on_module state function
fix power_good sysfs that returns empty string upon cable plug out
Work item tracking
How I did it
send 1 to hw_reset sysfs instead of existing 0 value sent to deassert hw_reset after power_on when needed
move seek(0) of sysfs fd before reading the sysfs fd
How to verify it
run the code in manual test of plugged out cable when the switch it booted.
then plug in the cable after module detection is done and dynamic detection takes place listening to sysfs changes via poller
for optic CMIS cable CMIS it will not be powered on thus will go into power_on_module function with the above change here.
at the end of module detection for this new cable inserted, EEPROM should be available for reading (currently with 0 sent to hw_reset EEPROM is not available at the end)
make sure power_good sysfs is not empty anymore upon cable plug out - it should have value of 0 when the cable is out
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)