temp commit for independent modules code #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarashinvd
force-pushed
the
dbarashi_indep_mode_temp
branch
3 times, most recently
from
1f4d884
to
599b44f
Compare
dbarashinvd
force-pushed
the
dbarashi_indep_mode_temp
branch
from
599b44f
to
4b85757
Compare
with final decision per port if it is FW or SW control
dbarashinvd
force-pushed
the
dbarashi_indep_mode_temp
branch
from
70c462f
to
90aa94e
Compare
and dynamic module detection
workaround for FW issue of eeprom access blocked for passive cables
added common code in functions added power_good sysfs countinga and poll dummy read added chassis thread destructor commented code
| @@ -123,6 +126,12 @@ def __init__(self): | |||
| self._RJ45_port_inited = False | |||
| self._RJ45_port_list = None | |||
|
|
|||
| self.threads = [] | |||
| self.modules_mgmt_thread = threading.Thread() | |||
There was a problem hiding this comment.
self.modules_mgmt_thread = None
| logger.log_info("timerTask waiting_modules_list after deletion: {}".format(self.waiting_modules_list)) | ||
| time.sleep(1) | ||
| i += 1 | ||
| def get_sysfs_legacy_ethernet_port_fd(self, sysfs_fd, port): |
There was a problem hiding this comment.
please change it and remove port breakout
| logger.log_info("add_port_to_wait_reset waiting_list after adding: {}".format(self.waiting_modules_list)) | ||
|
|
||
| def add_ports_state_to_state_db(self, dynamic=False): | ||
| state_db = None |
There was a problem hiding this comment.
please use global state_db instance
| logger.log_info(f"{detection_method} detection putting sfp_changes_dict {self.sfp_changes_dict} " | ||
| f"in modules changes queue...") | ||
| try: | ||
| self.modules_queue_lock.acquire() |
platform/mellanox/mlnx-platform-api/sonic_platform/modules_mgmt.py
Outdated
Show resolved
Hide resolved
since it does not return None anymore
and fix some issues
…shi_indep_mode_temp
…new table added to Redis DB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)