Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from structopt to clap v3 derive interface. #6

Merged
merged 4 commits into from
Jul 1, 2022
Merged

Switch from structopt to clap v3 derive interface. #6

merged 4 commits into from
Jul 1, 2022

Conversation

oylenshpeegul
Copy link

@oylenshpeegul oylenshpeegul commented Jul 1, 2022

Removed structopt dependency and added clap v3 with its optional derive interface.

Changed Opt to Args as that seems to be the clap style.

I think this fixes #4.

@dbaynard
Copy link
Owner

dbaynard commented Jul 1, 2022

Thanks for the PR! I think it probably fixes the issue, too. I might get rid of the extern crate business, which I think is superfluous — I’ll take a look over the weekend.

@dbaynard dbaynard self-assigned this Jul 1, 2022
@dbaynard dbaynard merged commit ca54ccf into dbaynard:master Jul 1, 2022
@oylenshpeegul
Copy link
Author

I guess you'll have to switch to edition 2018 or 2021 to ditch the extern stuff?

@dbaynard
Copy link
Owner

dbaynard commented Jul 2, 2022

Yeah but it’s not really worth it unless I do more work on this. And if that is to be the case, I’ll need to resolve #5 first.

Do you find the tool useful?

@oylenshpeegul
Copy link
Author

Honestly, I just stumbled on this because of the help wanted tag. Don't go to too much trouble on my behalf.

@dbaynard
Copy link
Owner

dbaynard commented Jul 2, 2022

Ah, cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace structopt with clap
2 participants