Fix an unexpected exception when using dsn without username & password #1134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the
-u, --user
flag is not provided and a DSN without theuser:pass@
part is used (such asmysql://localhost:3306/mydb
), an unexpected exception occurs. The expected behavior should be fallback to the current logged-in user (line 420 ofmain.py
, in theconnect
method).This is caused by an unchecked
None
value foruri.username
. This pull request fixes this bug.Example exception output:
Checklist
changelog.md
.AUTHORS
file (or it's already there).