Feature/proxied caller config #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… trace to obtain the caller information (for example when using custom LoggerService instead of injecting the NGXLogger)
qortex
previously requested changes
Jun 24, 2020
There was a problem hiding this comment.
Thanks for the PR!
I think it would be a nice addition. It would make sense to let the user choose how many steps should be skipped (in the PR, it is assumed this number is always 1).
Could you update the PR to a proxiedSteps: number and use that number instead of the boolean?
…teps When looking in stack trace, the user can now, the user is now allowed to specify a number of lines that will be ignored The parameter is proxiedSteps in LoggerConfig
|
@qortex I just updated the PR so that we have a number instead of a boolean, also added a comment on the config |
JanProchy
approved these changes
Jul 31, 2020
dbfannin
approved these changes
Feb 18, 2021
|
sorry guys, slept on the job! |
|
Thanks for sorting 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added configuration option called proxiedCaller, if this option is set to true then the caller information is resolved with an offset of +1.
This is useful when using an abstraction over the
NGXLoggersuch as a customLoggerService, that uses an injectedNGXLogger. In this scenario the caller information would always point to theLoggerServicefile, which is not very useful. With proxiedCaller: true configuration the caller information will be resolved to that which is calling theLoggerServiceand not theNGXLogger.Default value of
undefineddoes not change the current behavior, user must opt-in with a value oftrueto enable the new behavior.