Merge pull request trinodb#7 from academy-codex/mr_trino_sybase_conne…

…ctor_fixes Mr trino sybase connector fixes
dbit-xia · Jul 17, 2021 · b242817 · b242817
2 parents aff265a + 49ebdb0
commit b242817
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 19 deletions.
diff --git a/plugin/trino-sybase/src/main/java/io/trino/plugin/sybase/SybaseClient.java b/plugin/trino-sybase/src/main/java/io/trino/plugin/sybase/SybaseClient.java
@@ -56,7 +56,6 @@
 public class SybaseClient
         extends BaseJdbcClient
 {
-    // SqlServer supports 2100 parameters in prepared statement, let's create a space for about 4 big IN predicates
     public static final int SYBASE_MAX_LIST_EXPRESSIONS = 500;
 
     private static final Joiner DOT_JOINER = Joiner.on(".");

diff --git a/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/TestingSybaseServer.java b/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/TestingSybaseServer.java
@@ -90,22 +90,4 @@ public void execute(String sql, String user, String password)
             throw new RuntimeException(e);
         }
     }
-
-    public ResultSet executeQuery(String sql)
-    {
-        try {
-            Class.forName("net.sourceforge.jtds.jdbc.Driver");
-        }
-        catch (ClassNotFoundException e) {
-            e.printStackTrace();
-        }
-        try (Connection connection = DriverManager.getConnection(getJdbcUrl(), getUsername(), getPassword());
-                Statement statement = connection.createStatement()) {
-            return connection.getMetaData().getColumns("testdb", null, "Persons2", null);
-//            return statement.executeQuery(sql);
-        }
-        catch (SQLException e) {
-            throw new RuntimeException(e);
-        }
-    }
 }