Feature: Resolve chrome download url from api call #94
Comments
dbrekelmans
pushed a commit
that referenced
this issue
Feb 20, 2024
* Feature: Introduced a new DownloadUrlResolver, which can be used to find the specific download url for a version * Feature: Implement the new url resolver in the chromedriver downloader * Feature: Implement the new url resolver in the chromedriver downloader * Feature: Update the DownloaderTest * Feature: Small changes to the url resolver, and added a unit test * Feature: Change multiline call into one liner * Feature: Moved the binary and platform resolving logic to the DownloadUrlResolver * Feature: Remove the expected "with" argument * Feature: Updated test, to remove the binary param, and test all OS version on the old and new download endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is an api endpoint
https://googlechromelabs.github.io/chrome-for-testing/latest-patch-versions-per-build-with-downloads.jsonthat lists the url from which a specific version can be downloaded.It would be a nice improvement to base the download url, on the response from the api. Instead of hard coded download url's, as those are more prone to failure, whenever they decide to change it again. (Like what happened last thursday, but they quickly fixed in the same day)
The text was updated successfully, but these errors were encountered: