Use new Json endpoint for chrome driver #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrekelmans
requested changes
Aug 2, 2023
|
that's better now i think |
nvdbeek
reviewed
Aug 3, 2023
|
Praise: thanks for fixing this issue! |
nvdbeek
reviewed
Aug 3, 2023
KevinVanSonsbeek
approved these changes
Aug 3, 2023
nvdbeek
approved these changes
Aug 3, 2023
dbrekelmans
requested changes
Aug 4, 2023
dbrekelmans
requested changes
Aug 4, 2023
|
any updates? |
|
Hello @dbrekelmans and @Gurdarrag. I should have some spare times in next week, is it ok if I try to fix those last 2 issues in PR? If so, should I just commit into this branch, or create MR into this branch? |
|
Yes, by all means @Kamhal24! |
added 4 commits
September 6, 2023 19:04
# Conflicts: # src/Driver/ChromeDriver/Downloader.php
|
@Gurdarrag was faster 🙂 fyi, not only google created new endpoints, but the archive now contains folder with the driver. Older versions had just the driver without folder. In case anyone needed this info someday |
|
Sorry i was off from a month. |
|
Thanks @Gurdarrag! I'll try to release a beta version with this change as soon as possible! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.