Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #121: null pointer dereference at cli/wvunpack.c #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiaoxiaoafeifei
Copy link

@xiaoxiaoafeifei xiaoxiaoafeifei commented Jul 5, 2022

fix #121: null pointer dereference at cli/wvunpack.c:911

@dbry
Copy link
Owner

dbry commented Jul 6, 2022

Hi. I have pushed a more involved fix for this. Your PR would fix the test case, but fails if you add another instance of the file like this:

/usr/local/bin/wvunpack -m poc.wv poc.wv -o /

I also decided to sanitize the custom extensions from the library to be even safer.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null pointer dereference at cli/wvunpack.c
2 participants