Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue 1052 #1057

Merged
merged 9 commits into from
Oct 18, 2024
Merged

fix: issue 1052 #1057

merged 9 commits into from
Oct 18, 2024

Conversation

markussiebert
Copy link
Contributor

@markussiebert markussiebert commented Oct 9, 2024

Fixes #1052

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.30%. Comparing base (ce93ffa) to head (d334a88).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lambda/main.go 60.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1057      +/-   ##
==========================================
- Coverage   75.77%   72.30%   -3.47%     
==========================================
  Files           3        3              
  Lines         355      455     +100     
==========================================
+ Hits          269      329      +60     
- Misses         49       88      +39     
- Partials       37       38       +1     
Flag Coverage Δ
go-lambda 72.30% <85.71%> (-3.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions and others added 4 commits October 9, 2024 16:55
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
@markussiebert markussiebert self-assigned this Oct 10, 2024
@markussiebert markussiebert added the bug Something isn't working label Oct 10, 2024
@markussiebert markussiebert removed the request for review from henrysachs October 10, 2024 06:52
lambda/main.go Outdated Show resolved Hide resolved
@markussiebert markussiebert requested review from henrysachs and removed request for zh32 October 18, 2024 13:12
Copy link
Contributor

@henrysachs henrysachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markussiebert markussiebert merged commit 6f81b3b into main Oct 18, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClientRequestToken too short when using secret file from S3
3 participants