Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update connections.py with retry logic for 502 #563

Merged
merged 4 commits into from
Mar 9, 2023

Conversation

patkearns10
Copy link
Contributor

@patkearns10 patkearns10 commented Feb 26, 2023

resolves #562

Description

Checklist

@patkearns10 patkearns10 requested a review from a team as a code owner February 26, 2023 23:53
@cla-bot
Copy link

cla-bot bot commented Feb 26, 2023

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @patkearns10

@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@cla-bot cla-bot bot added the cla:yes label Feb 27, 2023
@dbeatty10
Copy link
Contributor

Thanks for opening this PR @patkearns10 !

You found exactly the right piece of code to update to add BadGateway 502 to the list of exceptions to retry.

Could you update the description to say resolves #562 instead of Potential Fix for #562? It might feel presumptive, but it will accomplish two things:

  1. ensure that the issue and the PR are linked on each page respectively
  2. will close the issue automatically if the PR gets merged

@Fleid Fleid linked an issue Mar 7, 2023 that may be closed by this pull request
@Fleid Fleid added ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering pr_tracked labels Mar 7, 2023
@colin-rogers-dbt colin-rogers-dbt merged commit 850296f into main Mar 9, 2023
@colin-rogers-dbt colin-rogers-dbt deleted the patkearns-502-BadGateway branch March 9, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
5 participants