Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Invalid where filter for latest batch when event_column is of type date #10868

Open
Tracked by #10624
QMalcolm opened this issue Oct 16, 2024 · 0 comments · May be fixed by #10883
Open
Tracked by #10624

[Bug] Invalid where filter for latest batch when event_column is of type date #10868

QMalcolm opened this issue Oct 16, 2024 · 0 comments · May be fixed by #10883
Assignees
Labels
bug Something isn't working microbatch
Milestone

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Oct 16, 2024

Currently, when running a microbatch model, the current time is right now. This, for the most part, just works. However, there is a problem.

Sometimes the event_time column is a date instead of a datetime. Now consider a model where the event_time is date_added which is a date type. The microbatch filter would then be something like date_added >= ‘2024-10-16 00:00:00’ and date_added < ‘2024-10-16 11:29:34’. Now, how does the data warehouse handle that? In some cases the datetime value gets auto truncated to a date, thus making the filter date_added >= ‘2024-10-16’ and date_added < ‘2024-10-16’. That is problematic because that filter will always return zero rows. To get around this, one solution could be to take the batch ceiling of the current time. That is, if our batch_size is day then 2024-10-16 11:29:34 would become 2024-10-17 00:00:00, and then upon truncation 2024-10-17.

@QMalcolm QMalcolm added bug Something isn't working microbatch labels Oct 16, 2024
@QMalcolm QMalcolm added this to the v1.9 milestone Oct 16, 2024
@QMalcolm QMalcolm self-assigned this Oct 18, 2024
@QMalcolm QMalcolm linked a pull request Oct 18, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working microbatch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant